fix(dashboard): save validation feedback, public site light mode, global verify modal (#716)

* fix(dashboard): surface save errors, force public site light mode, global verify modal

- Show snackbar with first validation error when course update fails client-side validation
- Force light mode on public org-site pages; lesson player and dashboard keep theme selector
- Mount VerifyEmailModal in root layout for all authenticated routes; keep trigger=app email guard

Co-authored-by: Rotimi Best <[email protected]>

* fix: instructor editor sync, auto-enroll after auth, email verification API

- Initialize instructor form from org fallbacks and batch metadata updates
- Auto-complete course enrollment after login/signup return from enroll page
- Block new org auto-enroll and course enroll until email is verified

Co-authored-by: Rotimi Best <[email protected]>

* fix: address PR review on instructor setter, color scheme, auto-enroll

- Use existing setter with batched metadata.instructor updates in InstructorForm
- Allowlist public org-site paths so /lms and /courses/:id keep theme selector
- Auto-enroll logged-in users via Better Auth session; remove sessionStorage flow
- Retry enrollment after email verification without duplicate Join Course clicks

Co-authored-by: Rotimi Best <[email protected]>

* fix: allow enrollment without verification; gate dashboard only

- Remove API email verification checks from enroll and auto-enroll flows
- Move VerifyEmailModal to (app) layout so public org-site pages stay usable
- Unverified users can enroll but hit the verification modal in LMS/dashboard

Co-authored-by: Rotimi Best <[email protected]>

* fix: address PR feedback on verify modal, routes, instructor form

- Restore currentOrg.id guard on VerifyEmailModal open condition
- InstructorForm imports currentOrg directly instead of prop drilling
- Move public org-site light-mode route patterns to routes constants
- Reset enrollment attempt key on enroll failure to allow retry

Co-authored-by: Rotimi Best <[email protected]>

---------

Co-authored-by: Cursor Agent <[email protected]>
Co-authored-by: Rotimi Best <[email protected]>

apps/dashboard/src/lib/utils/constants/routes.ts

@@ -20,6 +20,13 @@ export const ROUTE = {
   VERIFY_EMAIL_ERROR: '/verify-email-error'
 };
 
+export const PUBLIC_ORG_SITE_LIGHT_MODE_ROUTES = [
+  `^${ROUTE.HOME}$`,
+  `^${ROUTE.COURSES}/?$`,
+  `^${ROUTE.COURSE}/[^/]+/?$`,
+  `^${ROUTE.COURSE}/[^/]+/enroll/?$`
+] as const;
+
 export const PUBLIC_ROUTES = [
   `^${ROUTE.HOME}$`,
   ROUTE.LOGIN,

apps/dashboard/src/lib/utils/functions/color-scheme.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, it } from 'vitest';
+import { isPublicOrgSitePage } from './color-scheme';
+
+describe('isPublicOrgSitePage', () => {
+  it('returns false for non-org-site routes', () => {
+    expect(isPublicOrgSitePage(false, '/lms')).toBe(false);
+    expect(isPublicOrgSitePage(false, '/courses/abc')).toBe(false);
+  });
+
+  it('returns true for public org-site pages', () => {
+    expect(isPublicOrgSitePage(true, '/')).toBe(true);
+    expect(isPublicOrgSitePage(true, '/courses')).toBe(true);
+    expect(isPublicOrgSitePage(true, '/courses/')).toBe(true);
+    expect(isPublicOrgSitePage(true, '/course/my-course')).toBe(true);
+    expect(isPublicOrgSitePage(true, '/course/my-course/enroll')).toBe(true);
+  });
+
+  it('returns false for authenticated org-site app routes', () => {
+    expect(isPublicOrgSitePage(true, '/lms')).toBe(false);
+    expect(isPublicOrgSitePage(true, '/lms/settings')).toBe(false);
+    expect(isPublicOrgSitePage(true, '/courses/abc')).toBe(false);
+    expect(isPublicOrgSitePage(true, '/courses/abc/newsfeed')).toBe(false);
+    expect(isPublicOrgSitePage(true, '/course/my-course/lesson/intro')).toBe(false);
+  });
+});

apps/dashboard/src/lib/utils/functions/color-scheme.ts

@@ -0,0 +1,23 @@
+import { PUBLIC_ORG_SITE_LIGHT_MODE_ROUTES } from '$lib/utils/constants/routes';
+
+function normalizePathname(pathname: string): string {
+  const pathOnly = pathname.split('?')[0] ?? '/';
+  if (pathOnly === '/') {
+    return '/';
+  }
+
+  return pathOnly.replace(/\/+$/, '') || '/';
+}
+
+/**
+ * Public org-site pages (landing, catalog, course landing, enroll) always use light mode.
+ * Authenticated areas on the same tenant host (e.g. /lms, /courses/:id) keep the theme selector.
+ */
+export function isPublicOrgSitePage(isOrgSite: boolean, pathname: string): boolean {
+  if (!isOrgSite) {
+    return false;
+  }
+
+  const normalizedPath = normalizePathname(pathname);
+  return PUBLIC_ORG_SITE_LIGHT_MODE_ROUTES.some((pattern) => new RegExp(pattern).test(normalizedPath));
+}