feat: multiple choice question must all be correct before next question (#432)

This commit is contained in:
Rotimi Best
2024-08-11 21:47:00 +01:00
committed by GitHub
parent 4c0288fd84
commit 7428b21a09
3 changed files with 46 additions and 21 deletions
@@ -25,6 +25,7 @@
nextStatusId: number;
total: number;
}) => {};
export let isSaving = false;
const SELECTABLE_STATUS = [
{
@@ -128,7 +129,7 @@
'course.navItem.submissions.grading_modal.questions_tried'
)} ${answerPoints} `
};
data.questionAnswerByPoint[id] = `${points / answerPoints}`;
data.questionAnswerByPoint[id] = `${Math.ceil(points / answerPoints)}`;
} else if (aiResponses.length) {
const graded = aiResponses.find((res) => res.id === id);
@@ -335,8 +336,9 @@
<PrimaryButton
onClick={() => {
handleSave(data);
onClose();
// onClose();
}}
isLoading={isSaving}
label={$t('course.navItem.submissions.grading_modal.submit_grades')}
variant={VARIANTS.CONTAINED}
className="py-3 px-8 w-full"
@@ -5,6 +5,12 @@ export const isAnswerCorrect = (options, answer) => {
return options.some((option) => option.is_correct && option.value === answer);
};
/*
GRADING RULES
Textarea = no validation
Single = only one should be correct
Multiple = all should be correct
*/
export function wasCorrectAnswerSelected(currentQuestion, answers, isFinished) {
if (currentQuestion.question_type.id === QUESTION_TYPE.TEXTAREA) {
return true;
@@ -13,15 +19,20 @@ export function wasCorrectAnswerSelected(currentQuestion, answers, isFinished) {
const answer = answers[currentQuestion.name];
const formattedAnswers = typeof answer === 'string' ? [answer] : answer;
const isCorrect =
formattedAnswers &&
formattedAnswers.some((answer) => {
if (isAnswerCorrect(currentQuestion.options, answer)) {
return true;
}
return false;
});
let isCorrect = false;
if (currentQuestion.question_type.id === QUESTION_TYPE.CHECKBOX) {
// Every correct answer should be in the selected answer
isCorrect = currentQuestion.options
.filter((o) => o.is_correct)
.every((option) => formattedAnswers?.includes(option.value));
} else if (currentQuestion.question_type.id === QUESTION_TYPE.RADIO) {
// At least one correct answer should be selected
isCorrect = formattedAnswers?.some((answer) =>
isAnswerCorrect(currentQuestion.options, answer)
);
}
if (isCorrect && !isFinished) {
toggleConfetti();